impl: fall back to CODER_HEADER_COMMAND when the header command setting is blank - #350
Merged
Merged
Conversation
Contributor
Author
|
Pushed 5345773 to match the wording feedback on coder/jetbrains-coder#600: the |
fioan89
reviewed
Aug 19, 2026
|
|
||
| internal const val CODER_SSH_CONFIG_OPTIONS = "CODER_SSH_CONFIG_OPTIONS" | ||
|
|
||
| internal const val CODER_HEADER_COMMAND = "CODER_HEADER_COMMAND" |
Collaborator
There was a problem hiding this comment.
minor: at some point we should split the env keys from the persisted store keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as coder/jetbrains-coder#600 for the Toolbox plugin:
CoderSettingsStore.headerCommandfalls back to theCODER_HEADER_COMMANDenvironment variable when the stored setting is empty, matching the Coder CLI and the VS Code extension (src/settings/headers.ts), and following the existingsshConfigOptions/CODER_SSH_CONFIG_OPTIONSfallback in the same class. An unset variable still yieldsnull, so the default is unchanged; an explicitly configured setting still wins. README settings entry and theReadOnlyCoderSettingsdoc updated.Test:
CoderSettingsTest.testHeaderCommand(store / env / precedence), mirroringtestSSHConfigOptions.